Merged
Conversation
Created new enviornment from this repo, and it didn't work due to dependency errrors with the newer version of Networkx. to_scipy_sparse_matrix was outdated, so I changed it to to_scipy_sparse_array to fix the error.
This is associated with the change in core.py with to_scipy_sparse_array.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the code to fix a deprecated function error by replacing a deprecated NetworkX API call and updating dependency requirements.
- Replaces nx.to_scipy_sparse_matrix with nx.to_scipy_sparse_array in the core routing function.
- Updates the NetworkX dependency in pyproject.toml to ensure compatibility with the new API.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/track_linearization/core.py | Replaces deprecated API call with the updated version. |
| pyproject.toml | Updates dependency declaration to support the new API. |
Comments suppressed due to low confidence (2)
src/track_linearization/core.py:152
- Verify that the output type from nx.to_scipy_sparse_array is fully compatible with downstream code, as there may be subtle differences from the deprecated function.
nx.to_scipy_sparse_array(track_graph, weight="distance")
pyproject.toml:17
- Ensure that the specified minimum version for networkx (>=3.2.1) fully supports the to_scipy_sparse_array API; consider tightening the version requirement if the new API requires features from a later version.
dependencies = ["numpy", "scipy", "matplotlib", "pandas", "dask", "networkx>=3.2.1"]
Contributor
|
Sorry I am just getting to this. Thank you for catching this. I appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a new enviornment using the instructions on the documentation, and it outputted an attribute error while running it.
AttributeError: module 'networkx' has no attribute 'to_scipy_sparse_matrixMy environment has Networkx (3.42), and I followed recommendations to change to_scipy_sparse_matrix to to_scipy_sparse_array to fix the error. I also updated the toml file to be compatible with this change.